search

julianlam / nodebb-plugin-session-sharing

Allows login sessions from your app to persist in NodeBB
MIT License
88 stars 65 forks source link

PR for Issue #60 #65

Closed uplift closed 5 years ago

uplift commented 5 years ago

Had a bit of time so knocked this up for our needs. Does it work for you? I've gone for only one group list for both join/leave under the assumption that you'd want the same groups for each.

julianlam commented 5 years ago

Yes, this makes sense to me, simple and to-the-point :+1:

julianlam commented 5 years ago

LGTM unless you want to make the async change hehe

uplift commented 5 years ago

Missed the next variable in the arguments to handle the error. I'm happy with it currently unless you want me to change it?

julianlam commented 5 years ago

v4.3.5