julianlam / nodebb-plugin-session-sharing

Allows login sessions from your app to persist in NodeBB
MIT License
88 stars 65 forks source link

PR for #77 #79

Closed uplift closed 5 years ago

uplift commented 5 years ago

API for creating session-shared user

uplift commented 5 years ago

I've made the changes as you suggested and tidied it up so the logic lives in the controller file instead of library.js now

julianlam commented 5 years ago

Thank you @uplift -- I'm going to change createUser to process mostly to match the pre-existing method name (since they do nearly identical things). :smile:

julianlam commented 5 years ago

Oops, it's a POST, not a GET as indicated in the commit message. Ah well, POST is the correct choice anyhow.

julianlam commented 5 years ago

v4.6.0