julianlam
commented
6 years ago Thank you for your submission! I look forward to reviewing it tomorrow. I am impressed, will likely give you collaborator privilege so you can merge it in yourself 👍
On Thu, Apr 19, 2018, 19:30 juan-g, notifications@github.com wrote:
Since recently, Facebook Login gives only public profile and email by default. Any other data such as user friends will need an app review by Facebook. This pull request updates a line of library.js to the new default.
Currently, when using this NodeBB plugin to create a new app with Facebook Login, it doesn't work, and trying to register it says:
Submit for Login Review Some of the permissions below have not been approved for use by Facebook.
(...) will receive: your public profile, friend list and email address.
And, on Facebook for Developers:
We are not reviewing apps at this time due to changes we are making to the Facebook Platform.
With the small change of this pull request, it works for public profile and email. Of course, the user friends list is not needed at all for login.
Related info:
- Facebook will limit developers’ access to account data - The Verge https://www.theverge.com/2018/3/21/17148726/facebook-developer-data-crackdown-cambridge-analytica
- Overview - Facebook Login https://developers.facebook.com/docs/facebook-login/overview
- Reference - Facebook Login https://developers.facebook.com/docs/facebook-login/permissions
You can view, comment on, or merge this pull request online at:
https://github.com/julianlam/nodebb-plugin-sso-facebook/pull/47 Commit Summary
- Update to new Facebook policy
File Changes
Patch Links:
- https://github.com/julianlam/nodebb-plugin-sso-facebook/pull/47.patch
- https://github.com/julianlam/nodebb-plugin-sso-facebook/pull/47.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/julianlam/nodebb-plugin-sso-facebook/pull/47, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4VgyI3AiEHA9b4Le5dukbBfcXQ8_S5ks5tqR4QgaJpZM4Tcpc2 .
juan-g
Since recently, Facebook Login gives only public profile and email by default. Any other data such as user friends will need an app review by Facebook. This pull request updates a line of library.js to the new default.
Currently, when using this NodeBB plugin to create a new app with Facebook Login, it doesn't work, and trying to register it says:
And, on Facebook for Developers:
With the small change of this pull request, it works for public profile and email. Of course, the user friends list is not needed at all for login.
Related info: