julianlam / nodebb-plugin-sso-google

NodeBB Plugin that allows users to login/register via their Google account.
BSD 2-Clause "Simplified" License
20 stars 16 forks source link

Crash when deleting users #6

Closed lekoder closed 9 years ago

lekoder commented 9 years ago

When trying to delete users, forum crashes with:

29/12 21:21 [910] - error: ReferenceError: async is not defined
    at Object.Google.deleteUserData [as method] (/home/fotopasozyty/nodebb/node_modules/nodebb-plugin-sso-google/library.js:133:3)
    at /home/fotopasozyty/nodebb/src/plugins.js:423:12
    at /home/fotopasozyty/nodebb/node_modules/async/lib/async.js:272:13
    at iterate (/home/fotopasozyty/nodebb/node_modules/async/lib/async.js:149:13)
    at /home/fotopasozyty/nodebb/node_modules/async/lib/async.js:160:25
    at /home/fotopasozyty/nodebb/node_modules/async/lib/async.js:274:17
    at /home/fotopasozyty/nodebb/node_modules/nodebb-plugin-sso-facebook/library.js:142:4
    at try_callback (/home/fotopasozyty/nodebb/node_modules/redis/index.js:573:9)
    at RedisClient.return_reply (/home/fotopasozyty/nodebb/node_modules/redis/index.js:661:13)
    at ReplyParser.<anonymous> (/home/fotopasozyty/nodebb/node_modules/redis/index.js:309:14)

Users do get deleted.

NodeBB v0.6.0. Nodebb-plugin-sso-google 0.4.2

julianlam commented 9 years ago

Thanks :smile:

lekoder commented 9 years ago

Still crashes further on:

30/12 08:33 [2962] - error: ReferenceError: user is not defined
    at Object.Google.deleteUserData [as method] (/home/fotopasozyty/nodebb/node_modules/nodebb-plugin-sso-google/library.js:135:16)
    at /home/fotopasozyty/nodebb/src/plugins.js:423:12
    at /home/fotopasozyty/nodebb/node_modules/async/lib/async.js:272:13
    at iterate (/home/fotopasozyty/nodebb/node_modules/async/lib/async.js:149:13)
    at /home/fotopasozyty/nodebb/node_modules/async/lib/async.js:160:25
    at /home/fotopasozyty/nodebb/node_modules/async/lib/async.js:274:17
    at /home/fotopasozyty/nodebb/node_modules/nodebb-plugin-sso-facebook/library.js:142:4
    at try_callback (/home/fotopasozyty/nodebb/node_modules/redis/index.js:573:9)
    at RedisClient.return_reply (/home/fotopasozyty/nodebb/node_modules/redis/index.js:661:13)
    at ReplyParser.<anonymous> (/home/fotopasozyty/nodebb/node_modules/redis/index.js:309:14)

NodeBB v0.6.0. Nodebb-plugin-sso-google 0.4.3