search

julianpeeters / avrohugger

Generate Scala case class definitions from Avro schemas
Apache License 2.0
201 stars 120 forks source link

Add support for UUIDs #101

Closed agustafson closed 6 years ago

julianpeeters commented 6 years ago

Fantastic contribution @agustafson, I imagine this will make people very happy.

Would you be able to take on the addition of some scripted serialization tests, to confirm the generated types behave as expected? (i.e. adding to the existing specs for Standard format from avdl and avsc, and existing specs for SpecificRecord format from avdl and avsc)

agustafson commented 6 years ago

Happy to contribute, thanks for your great work on avrohugger 😀 I'll add some of scripted tests sometime this week if i get a chance, but I don't believe that the uuid logicalType is supported by avdl: https://avro.apache.org/docs/1.8.2/idl.html#logical_types

agustafson commented 6 years ago

Good shout on running the scripted tests @julianpeeters - I found an error as it couldn't handle org.apache.avro.util.Utf8s. Have updated this PR to handle all java.lang.CharSequences.

julianpeeters commented 6 years ago

Awesome @agustafson, this is up at sonatype now as avrohugger version 1.0.0-RC13 and sbt-avrohugger version 2.0.0-RC13, expected to sync up with maven central shortly.

agustafson commented 6 years ago

Fantastic! Thanks for giving such quick feedback and approving so quickly @julianpeeters. And the level of testing in sbt-avrohugger is really impressive. Makes it easier to make contributions to the project 👍