julianredmond / julianredmond.ca

The starter portfolio repository, basically empty, but with a few helper files.
https://angry-jackson-0923ea.netlify.com/pattern-library/#brand
0 stars 0 forks source link

Peer Critique #5

Open jmjones715 opened 4 years ago

jmjones715 commented 4 years ago

The about card is perfectly responsive, but the line length is a bit long for larger screen sizes. Consider putting a max-length class on the text tag. The other cards are also well coded and responsive. Your footer has a good start and is responsive, but it looks a bit unfinished.

Your header is goo too, but could use a bit more space in between links for mobile screens. Also, your links should be in an a tag, so that users can click on them.

Overall, the library is looking clean with very minimal issues. Keep finishing everything up, and add more rationales!

0 points 1 points 2 points 3 points
Creativeness Bland, boring Fairly generic, but the colours are nice Good, works very well and is unique enough Wow! I never would have thought that would work so well!
Effectiveness I don’t know what this is trying to do The message isn’t completely clear and it’s difficult to use It’s obvious and simple to use The project is super effective and easy to use
Quality Non-existent Acceptable quality, more work could be done Good quality, up to the expectations of the teacher Stunning quality, this person rocks!
Effort Zero effort, incomplete Decent amount of effort Goodly amount of effort that shows Amazing, over-the-top amount of effort
Code quality Barely started Indentation is barely existent, lots of validation errors, very poor semantics Decent indentation, just a couple validation errors, decent semantics Well indented, fully valid, good semantics

Grade: 13/15