Fix update on different song in album

julianschiavo / SimplePresence

An easy and simple way to set your Discord Rich Presence Status through RPC (no token required)

GNU General Public License v2.0

194 stars 37 forks source link

Fix update on different song in album #9

Closed Alipoodle closed 6 years ago

Alipoodle commented 6 years ago

Currently Google Play Music's Total and Current Time are slightly broken and won't always report back with the correct amount! Issue from GPMDP Github

Because of this, in the If statement on line 174 it won't always trigger if someone is constantly listening through an album. The Album Art stays the same, Google caches the next song so it doesn't pause briefly between songs, and the total time doesn't change due to this bug!

julianschiavo commented 6 years ago

Shouldn't the total time be different though (so either album art or total time is enough of a check)?

Alipoodle commented 6 years ago

Because Google Play Music doesn't have an official APIs, Google Play Music Desktop Player has to find the Total and Current length of the Track in it's own means! The current public version of the program still has this error and sometimes fails to update the total and current length. Sometimes it simply returns back 0s as I try to see if it was a simple restart fix!

Alipoodle commented 6 years ago

Top is a Rain Meter thing I have that uses the API. Bottom is Google Play Music Desktop Player (Mini player)

julianschiavo commented 6 years ago

Accepted. Thanks for your contribution to SimplePresence.