search

julianschill / klipper-led_effect

LED effects plugin for klipper
GNU General Public License v3.0
647 stars 117 forks source link

Added IMMEDIATE param to SET_LED_EFFECT so you don't need to wait for… #112

Closed moggieuk closed 1 year ago

moggieuk commented 1 year ago

The use case is switching leds from led-effect control to straight RGB in a single macro. The IMMEDIATE flag stops the effect immediately. That allows for setting via standard LED control immediately afterwards without waiting form the effect to turn at the next scheduling event.

julianschill commented 1 year ago

Thank you for your PR. I think I already adressed this problem in the current develop branch. Let me know if I am mistaken.

This is the commit: https://github.com/julianschill/klipper-led_effect/pull/102/commits/1feb95e826af1fa14d6959a6e344ba19095b0fd9

moggieuk commented 1 year ago

Ah, ok. So with your development branch setting FADETIME=0 will have the same effect. Cool! I'll pull the development branch and give it a try it is otherwise relatively stable.

moggieuk commented 1 year ago

Yes, your logic works great. You can close this pull request.

julianschill commented 1 year ago

Thanks for the feedback. I also released develop to master yesterday.