search

julianschill / klipper-led_effect

LED effects plugin for klipper
GNU General Public License v3.0
645 stars 117 forks source link

Update LED_Effect.md #175

Closed landscapejohn closed 3 months ago

landscapejohn commented 4 months ago

Add "endstops" parameter to "Homing" effect documentation

julianschill commented 4 months ago

These parameters describe the parameters sof they layer. The endstops parameter is not part of the layer line but of the effect parameters which are described further up.

julianschill commented 4 months ago

I think a comment in the description that the endstops parameter has to be defined for the effect would make sense, though.

landscapejohn commented 4 months ago

Oh, okay, I must have missed that. Thanks!

John Hodge

On Feb 22, 2024, at 1:54 AM, Julian Schill @.***> wrote:



I think a comment in the description that the endstops parameter has to be defined for the effect would make sense, though.

— Reply to this email directly, view it on GitHubhttps://github.com/julianschill/klipper-led_effect/pull/175#issuecomment-1958886224, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABDZ4YPS6W6NVZMHEQN7AWDYU32RHAVCNFSM6AAAAABDULKTGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJYHA4DMMRSGQ. You are receiving this because you authored the thread.Message ID: @.***>