search

juliansteenbakker / community_charts

This project is a fork of google/charts.
Apache License 2.0
83 stars 35 forks source link

Points incorrectly rendered on line graph #24

Open everclear opened 2 months ago

everclear commented 2 months ago

LineRendererConfig(includePoints: true)

Point are rendered as lines above the chart instead of points on the line.

charts

PerLycke commented 2 months ago

The issue is introduced in commit 2b2f6bb9be800940a6c2ee3a55b9f020a38b9f6b ("add a PointLabelDecorator to render a label for a point"). This commit causes the points in a points line chart to be rendered on top of the chart, rarely visible, rather than on the chart where they should be rendered.

Steps to Reproduce

  1. Use the plugin to create a Points Line Chart, or run the example app and open the Points Line Chart.
  2. Observe that the points are rendered above the chart as seen in this screenshot:

Screenshot_1718264643

Observed Behavior

The points are rendered on top of the chart, rarely visible.

Expected Behavior

The points should be rendered on the chart at their correct positions.

Additional Information

Reverting commit 2b2f6bb9be800940a6c2ee3a55b9f020a38b9f6b resolves the issue, and the points are rendered correctly on the chart, as seen in this screenshot:

Screenshot_1718264679

Please let me know if further details are needed.

PerLycke commented 3 weeks ago

@RonnieRen

Your pull request causes this bug:

https://github.com/juliansteenbakker/community_charts/pull/18

Just FYI, if you want to check this out.