juliantayyc / pe

0 stars 0 forks source link

Inaccurate error response message for invalid name #2

Open juliantayyc opened 2 weeks ago

juliantayyc commented 2 weeks ago

Suppose the user is unaware of the restrictions made to Name field that disallows non-alphanumeric characters and wishes to add the following patient Bala s/o Kumar as shown.

image.png

The following error message is provided as feedback to the user:

Multiple values specified for the following single-valued field(s): s/

However, this is not necessarily correct as the repeated s/ detected is due to the patient's name and not because the user has intended to repeat the s/ field.

The team can consider revising the exception handling to accurately distinguish between:

  1. Invalid Name
  2. Multiple values specified for single-valued fields
soc-se-bot commented 1 week ago

Team's Response

While some names do include special characters, they can often be omitted or modified without compromising their recognizability or clarity. For instance, in Indian names where slashes (e.g., in "s/o" or "d/o") are commonly used - particularly in Singapore - users can opt for the unabbreviated forms ("son of" or "daughter of") or simply omit these elements.

Sauce: https://culturalatlas.sbs.com.au/singaporean-culture/singaporean-culture-naming#indian-naming-conventions

Though we plan to include such special characters in future iterations but the work to ensure that the parser correctly recognises each flag or name takes much more work that the benefits that it reaps. Thus, making it out of scope.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name field does not accept slashes, dashes and apostrophes; prefix conflict for "s/o" and "s/"

Screenshot 2024-11-15 at 17.06.45.png

While this has been noted in the future enhancements section, there is no explanation as to how the problem will be solved. Additionally, as can be seen in the screenshot above there is no explanation as to how the prefix conflict between "s/o" in a name field and "s/" as the status field prefix will be solved.

Again, to exempt a bug from being counted in the PE, it must be under a "Planned Enhancements" section in the DG with details on how the enhancement will be implemented.


[original: nus-cs2103-AY2425S1/pe-interim#3353] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

While some names do include special characters, they can often be omitted or modified without compromising their recognizability or clarity. For instance, in Indian names where slashes (e.g., in "s/o" or "d/o") are commonly used - particularly in Singapore - users can opt for the unabbreviated forms ("son of" or "daughter of") or simply omit these elements.

Sauce: https://culturalatlas.sbs.com.au/singaporean-culture/singaporean-culture-naming#indian-naming-conventions

Though we plan to include such special characters in future iterations but the work to ensure that the parser correctly recognises each flag or name takes much more work that the benefits that it reaps. Thus, making it out of scope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]