search

julianwachholz / django-guest-user

A Django app that allows visitors to interact with your site as a guest user without requiring registration.
https://django-guest-user.readthedocs.io/
MIT License
74 stars 10 forks source link

Add django-tos contrib app #5

Closed blag closed 1 year ago

blag commented 1 year ago

This PR adds an integration with django-tos.

It is necessary when using django-tos's middleware option (2). When using django-tos' middleware, since guest users have full user accounts they are required to agree to the site's terms of service before they can do anything else.

I have refactored django-tos a bit in revsys/django-tos#65 specifically to make this custom middleware easier to write. That PR allows us to minimize the amount of code necessary in this middleware and any changes to upstream django-tos should not interfere with this middleware.

julianwachholz commented 1 year ago

Hi @blag thank you for this contribution! I think this could be added but if I understand it correctly it depends on the linked PR being merged into django-tos first?

blag commented 1 year ago

Sorry I wasn't clear about that - yes, it needs the linked PR to be merged first. That maintainer is pretty active though, so it hopefully shouldn't take too much longer.

julianwachholz commented 1 year ago

Thanks for your contribution and continued support of this project @blag :)

blag commented 1 year ago

Thank you for maintaining it for me and the Django community. Happy New Year! 😄