julianwachholz / flake8-action

Run flake8 linter in your Python project.
https://github.com/marketplace/actions/python-flake8
MIT License
29 stars 9 forks source link

Resource not accessible by integration #2

Open m-kuhn opened 4 years ago

m-kuhn commented 4 years ago

Are annotations supposed to be working?

On a sample run I could not see them and wonder if it's a configuration issue or by design. The former repository claimed to do this (but it never actually worked). From what I get, this would need to be installed on the repository (compared to just editing a yml file), but I never digged that deep.

Anyway, thank you for taking over !

julianwachholz commented 4 years ago

Annotations are working correctly! I added a broken Python file in this repository which gets linted in a unit test. See the run here: https://github.com/julianwachholz/flake8-action/runs/794134740 (The status is set to ignored for the test suite)

m-kuhn commented 4 years ago

I get a "Resource not accessible by integration" error. See also https://github.com/julianwachholz/flake8-action/runs/806242776#step:4:29

It could be related to different permissions if doing a pull request from a different repository vs. a commit on a branch in the repository.

See also https://github.com/actions/first-interaction/issues/10 (more specifically, this comment https://github.com/actions/first-interaction/issues/10#issuecomment-570991638)

liskin commented 4 years ago

I had a similar problem with this. Turns out there is a different solution not involving token access scopes: use Problem Matchers and let GitHub Actions parse the errors/warnings directly from flake8 output.

Here's my Action that follows this path: https://github.com/liskin/gh-problem-matcher-wrap and here are example pull requests on my python repo to demonstrate it working: https://github.com/liskin/strava-offline/pull/2/files, https://github.com/liskin/strava-offline/pull/3/files