search

julianxhokaxhiu / FFNx

Next generation modding platform for Final Fantasy VII and Final Fantasy VIII ( with native Steam 2013 release support! )
GNU General Public License v3.0
356 stars 48 forks source link

[ FF7 ] Shadow Flare has an incorrect rendering between PC and PSX #279

Open DLPB2 opened 3 years ago

DLPB2 commented 3 years ago

Issue: Shadow Flare (for example) is broken and always has been. An exception may be needed to fix. It's even worse with ffnx than default Aali.

This may be why:

"Alpha blending transparency is broken. The issue is that the PC renderer has two different alpha values (vertex alpha, texture alpha) and the game doesn't specify which one to use (AFAIK), so, sometimes, the correct thing to do is to just use texture alpha, sometimes vertex alpha, and, sometimes, the two should be combined to produce the correct result. The way it works now (with the Custom Driver) is correct most of the time, but not always." - Aali

PSX:

shadow-flare-psx

PC:

shadow-flare-pc
julianxhokaxhiu commented 3 years ago

Thanks for the report, have you got a save that I can use to replicate the issue and can you please share some steps on how to reproduce? This would be really appreciated. I'll look into this but I can't promise any ETA.

DLPB2 commented 3 years ago

You can reproduce it just by using the enemy skill Shadow Flare. It will always come out with the wrong colours. We've verified it isn't the texture file.

julianxhokaxhiu commented 2 years ago

Were you able to find at least a lead around this? I did try to check via RenderDoc but I couldn't find anything strange being done in the pipeline. Should be a deep buried bug in the engine code, as always...

DLPB2 commented 2 years ago

No idea what causes it or anything else... it's likely entirely graphics related

julianxhokaxhiu commented 2 years ago

Do you have an idea at which address is this effect being called in the exe? I might have a solution but I need to double check how the blending is set for this texture.