julianxhokaxhiu / FFNx

Next generation modding platform for Final Fantasy VII and Final Fantasy VIII ( with native Steam 2013 release support! )
GNU General Public License v3.0
365 stars 49 forks source link

[ FF7 ] Collection of widescreen 16:9 bugs #474

Open CosmosXIII opened 2 years ago

CosmosXIII commented 2 years ago

This is the collection of bugs related to the new widescreen 16:9 aspect ratio mode.

Common

Field mode

Battle mode

Worldmap mode

Other modes

Before reporting new bugs/glitches, make sure you are running the latest canary version of FFNx. Also double check if the bug or glitch is not already in this list

KuraudoXS commented 2 years ago

7th 2.6.14 FFNx 1.13.0.8

Fields 1) fship_24 (fship_2, fship_25 not prolly) - As soon as you step in the Highwind the animation background is not wide, resulting in a black background on both sides close to the animation. Final Fantasy VII 08_08_2022 5_08_09 PM 2) junbin21 - PSX scene FYR https://youtu.be/ub0qHDFZayE?t=34415 (9:33:35) FYI This field has an issue, the camera following Heidegger is going way too up the field and it's showing an "out-of-boundary" area, above the curtains, which is not supposed to be visible. vlcsnap-2022-08-19-12h20m09s349

Worldmap 1) The worldmap UI position is not bottom right corner as it was before true widescreen. Final Fantasy VII 9_26_2022 10_45_29 PM Final Fantasy VII 9_26_2022 10_46_03 PM

Spells animations 1) Pollensalta at Northern Cave - The full screen spell texture is not following true widescreen vlcsnap-2022-09-01-00h42m39s131

FMV 1) Opening Movie transition from CG to Field it's a bit too evident, this is obviously out of scope and low priority but could be an idea to have a "smoke effect from the train" a la FFVII Remake to enhance this? ( YT: https://youtu.be/QQuw6Es6jGc?t=246 4:06 )

Other Mod - Compatibility issue 1) Compact Battle UI has black background right and left. (DEPRECATED, USE IFRIT MOD) 2) ESUI: The command "Defend" and "Change" appear for a frame only and then disappears. Final Fantasy VII 19_08_2022 11_51_12 AM 3) ESUI + Finishing Touch: Limit break red string is out of the battle window. Possible to replicate selecting mini-faces as a Finishing Touch option. (FIXED)

Specs CPU: i7-10870H RAM: 16GB DDR4 GPU: RTX 3060

Resolution 1920x1080 Widescreen on Internal resolution *4 Antialiasing: off Antisotropic: on Vertical sync: on Advanced Lighting: on

AnsgarTOdinson commented 2 years ago

16:9 aspect ratio stretches to fill the screen when displayed on an ultrawide monitor. Native 4:3 mode does not. This applies to everything. Fields, battles, menus, FMVs, everything.

tangtang95 commented 2 years ago

@KuraudoXS found this field map 'junbin21' having some problem with top camera range. Need to fix it in future config.toml

Sdub-12 commented 2 years ago

7th v2.6.1.10 FFnx 1.13.0.55 (Located I was unable to locate the number, it was not displaying on the screen for borderless window it was displayed when using Fullscreen. )

Describe the bug 16:9 Mode is causing shop characters/text to appear incorrectly/moved. The issue seems to be specifically to shop prices. Will attach screenshots. Using Canary build.

To Reproduce

  1. Go to Gamedriver Settings
  2. Enable 16:9 Widescreen
  3. Begin Game
  4. Enter Shop interface
  5. See error

Expected behavior I expected the prices to appear normally as is with 4:3

Screenshots

Shops with WS Shops Without  WS ZeroModUsing ZeroModNotUsing

Settings I was using settings

GPU (please complete the following information):

Additional context Feel free to reach out to me anytime, I am Sdub in the Qhimm discord

julianxhokaxhiu commented 2 years ago

@Sdub-12 when putting reports please make sure you tell which is the FFNx version you used, not the date. Thank you.

Sdub-12 commented 2 years ago

@Sdub-12 when putting reports please make sure you tell which is the FFNx version you used, not the date. Thank you.

Updated, I was unable to locate the number at the time, it was not displaying on the screen for borderless windowed mode, Was displayed when using Fullscreen. Apologies, Ive only been using the program for less than a week

tangtang95 commented 2 years ago

@CosmosXIII Regarding the menu shop scissor glitch, it's probably not going inside this if condition https://github.com/julianxhokaxhiu/FFNx/blob/master/src/renderer.cpp#L1237. You did it also for swirl, but is it really necessary?

CosmosXIII commented 2 years ago

@CosmosXIII Regarding the menu shop scissor glitch, it's probably not going inside this if condition https://github.com/julianxhokaxhiu/FFNx/blob/master/src/renderer.cpp#L1237. You did it also for swirl, but is it really necessary?

yeah, I fixed the conditions in this PR and the shop glitch is fixed now: https://github.com/julianxhokaxhiu/FFNx/pull/484 the swirl one did not need that condition so I removed it

Sdub-12 commented 2 years ago

Canary 7th v2.6.1.20 FFNx v1.13.0.75

Describe the bug When doing anything with the Chocobo Farm (Moving, Breeding, Riding) It does not show the Black screen with the chocobo. It instead just shows the top of the barn with the information from the Chocobo as seen in the screenshots below.

To Reproduce Have widescreen mode on Attempting to use chocobo farm.

Expected behavior To be able to see the traditional chocobo screen

Screenshots image image image image

GPU (please complete the following information):

NVIDIA GeForce GTX 1060 3GB
GeForce Game Ready Driver Version 516.94

Additional context Let me know if you need any further information.

Neffina commented 2 years ago

Fight

I noticed that in the penultimate boss fight in 16:9 format, the boss is not really displayed. The pens on his head are too far away. It's not because of the model, if 16:9 is deactivated, everything is correct.

SirDevil99 commented 2 years ago

Desktop Screenshot 2022 09 10 - 07 54 17 34-min

This affect doesn't scale properly in Gaea’s Cliff as it is only a box as shown in the image above.

Canary 7th v2.6.1.20 FFNx v1.13.0.75

GPU RTX3080 - Driver 516.94

chrcoluk commented 2 years ago

If ESUI limit box issue is fixed I appreciate that, I was going to fix inside ESUI itself, so thank you.

LaZar00 commented 2 years ago

Using: Canary FFNx 1.13.0.83 7H 2.6.1.25

In fship_22, when Cloud reach the tornado, we can see Highwind with Rufus, Heidegger, Scarlet, Hojo... In the 16:9 version, the scroll does not pans to the bottom when Hojo speaks. I leave 4:3 version and 16:9 version to see differences.

https://user-images.githubusercontent.com/46090031/191134625-ae14cbea-3fd5-479f-95fd-5a8cd9148334.mp4

https://user-images.githubusercontent.com/46090031/191134730-110c6920-4ff2-46df-b52b-54513586294d.mp4

LaZar00 commented 2 years ago

Using: Canary FFNx 1.13.0.83 7H 2.6.1.25

I wouldn't say this is a bug, maybe an enhancement.

In trnad_3 (704), I think that the width of the field is enough wide to use the 16:9 proportion. But you must walk for scroll/pan horizontally the field view... I'm not sure if this is normal or it is as is. Obviously I have configured FFNx as 16:9.

UPDATE 20/09/2022: This issue happens also in trnad_4 (705). But changing this maybe it breaks the effect of panning of the stage when appears Sephirot.

https://user-images.githubusercontent.com/46090031/191136161-7d1b3623-ccee-442c-b368-37cfa0ea0aab.mp4

LaZar00 commented 2 years ago

Using: Canary FFNx 1.13.0.84 7H 2.6.1.25

Another widescreen issue appears the first time we get Highwind (without Cloud). Your character is Tifa and you must go down to the bridge. Then there is a sequence where Barret and Cait are present and there is a pan movement of the field to the right, but then later, the camera stays, because the pan to the left reachs the edge (I assume), and Barret and Cait disappear magically xD.

https://user-images.githubusercontent.com/46090031/191497471-d1507a28-09db-491a-8f33-b701cc95f089.mp4

LaZar00 commented 2 years ago

Using: Canary FFNx 1.13.0.84 7H 2.6.1.27

Great Gospel Limit 4 of Aeris shows the black background in the edges of the box:

imagen

CosmosXIII commented 2 years ago

@LaZar00 trnad_3 and trnad_4 have scrolling but not enough to fill widescreen. These ones remain 4:3 for now but we are working on solutions for those.

LaZar00 commented 2 years ago

@CosmosXIII I was not sure if it would fill all the 16:9 aspect. But it's ok. I only reported it because I've seen some field backgrounds showing all the image even it does not fill 16:9 aspect ratio. In any case, you are doing a great job with widescreen!

julianxhokaxhiu commented 2 years ago

Closed by mistake. Re-opened.

LaZar00 commented 2 years ago

Using: Canary FFNx 1.13.0.84 7H 2.6.1.27

Great Gospel Limit 4 of Aeris shows the black background in the edges of the box:

imagen

About this issue, the model/box of the sky it is in magic.lgp. The RSD file using it is SKY_A.RSD, that uses the model SKY_A.P and the texture SKY_1.TEX. Maybe doing bigger that model box the issue is solved.

LaZar00 commented 2 years ago

Using: Canary FFNx 1.14.0.1 7H 2.7.0.1

I'm checking some of the models of the ESkills, and I've found this issue while using widescreen 16:9. This is the ESkill "Pandora's Box". You can see the bright light of the beginning initiates the left part where 4:3 aspect should be, although it finishes correctly to the right of the screen.

Another issue would be the colored rays that come from behind the question symbol. They seem to be 4:3. I'm not sure if those can be enhanced to accept 16:9.

https://user-images.githubusercontent.com/46090031/192359326-415f75af-cb23-4da9-83b2-8303e76a57b5.mp4

LaZar00 commented 2 years ago

Using: Canary FFNx 1.14.0.1 7H 2.7.0.8

When you go for the Huge materia of Mt. Corel, you have to do the minigame of the little train. In this case, you have to go wagon by wagon until reach the locomotive and stop the train.

In the video you can see how part of the mountain (top left part of the image) is rendered at certain point, leaving some part without rendering. This happens in other camera views of this sequence also.

https://user-images.githubusercontent.com/46090031/193342093-f1b5d56e-fa3f-4753-8a5b-71fa5fd25f75.mp4

LaZar00 commented 2 years ago

Using: Canary FFNx 1.14.0.1 7H 2.7.0.8

Ok, another magic trick, this time with Young Cloud, like the one of Barret/Cait Sith in Highwind and Tifa. This is one of those that is best to update at field level.

https://user-images.githubusercontent.com/46090031/196009240-fd7aedfa-7d23-46d4-b0db-7c843c44194b.mp4

chrcoluk commented 2 years ago

Something that can affect trying to do WS on vanilla battle layout is if box width is wider than 4:3 size the scroll boxes stop rendering, let me know if you want a clip.

tangtang95 commented 2 years ago

Something that can affect trying to do WS on vanilla battle layout is if box width is wider than 4:3 size the scroll boxes stop rendering, let me know if you want a clip.

Yeah, if you have an image, or even a way to test it, it would help a lot

LaZar00 commented 2 years ago

Using: Canary FFNx 1.14.0.1 7H 2.7.0.8

Well, the last positional bug I found for Widescreen. I think that three are all possible, but who knows. I have not checked 100% of the game.

https://user-images.githubusercontent.com/46090031/197620117-82fa8384-0a27-49f6-8fb4-5bc370fd5209.mp4

LaZar00 commented 1 year ago

Canary FFNx 1.15.0.46 7H 3.0.0.1

Found this issue with the sunrays layer of the field. I assume it is widescreen (the other fields seems to work well in widescreen): imagen

julianxhokaxhiu commented 1 year ago

See also #620