search

juliarn / npc-lib

Asynchronous, high-performance Minecraft NPC library for 1.8-1.21 servers.
MIT License
296 stars 50 forks source link

NPC orientation fixes #110

Closed DasBabyPixel closed 1 year ago

DasBabyPixel commented 1 year ago

First commit removes unnecessary check if the player orientation changed (bukkit) Second commit should fix NPC orientation when a player moves on bukkit and minestom Third commit should fix the same NPC orientation bug from #108 on minestom Haven't been able to test any of the commits yet and probably won't be able to do so until late afternoon/evening. Just wanted to make this PR to remove redundant work if any of you wanted to start working.

derklaro commented 1 year ago

I just cleaned the code in this PR up a bit - it looks good to me just by looking at the code, let me know about your test results and I will merge changes :)

DasBabyPixel commented 1 year ago

Noticed that on minestom the npc won't appear until the player moves. Also fixed that in the last commit Never mind the commits that I undid, intelij autoformat screwed me over. Tested on bukkit and minestom and everything worked.