search

juliarn / npc-lib

Asynchronous, high-performance Minecraft NPC library for 1.8-1.21 servers.
MIT License
296 stars 50 forks source link

Proper publishing #113

Closed DasBabyPixel closed 11 months ago

DasBabyPixel commented 1 year ago

The groupId in the pom.xml is lowercase while the group for the repository is mixed-case. This creates fun like this: image Here is a demo project for the problem. The master branch has the problem, the workaround branch uses this workaround. Even though with the workaround everything is fine, this should really be fixed on the repository. I have seen that beta5 seems to be published mixed case (with the wrong pom) and all lowercase (which works fine) In case this is regarding this exact issue, then updating the release notes might be appropriate.

derklaro commented 1 year ago

The issue here is that the lib is only destributed via Jitpack. Jitpack is not really nice when it comes to problems like this, I suppose when this lib gets published into a "real" maven repository the issue will be fixed.

DasBabyPixel commented 1 year ago

I am not using jitpack though... https://github.com/DasBabyPixel/NPC-Lib-Demo/blob/68ac91302b97440fde1306e9282769a5f3e67d3a/build.gradle.kts#L7

derklaro commented 1 year ago

My repository is a partial jitpack mirror due to the unreliability of jitpack.

DasBabyPixel commented 1 year ago

Now that does make sense. Any time frame on a "real" repository? Or maybe publishing to central?

derklaro commented 11 months ago

Update: I've just published the latest 3.0.0 snapshot to sonatype (repo url is https://s01.oss.sonatype.org/). The project is now using the group id io.github.juliarn. Can you let me know if everything works as expected now?

DasBabyPixel commented 11 months ago

Everything seems to work correctly now with sonatype. Might want to add documentation for future reference.

derklaro commented 11 months ago

Will do that, thanks for testing! 😄