search

juliarn / npc-lib

Asynchronous, high-performance Minecraft NPC library for 1.8-1.21 servers.
MIT License
290 stars 51 forks source link

Don't shade packetevents #114

Open vytskalt opened 10 months ago

vytskalt commented 10 months ago

I think it would be great if packetevents wasn't shaded in the library and it was up to the user to do so. In my case I already depend on ProtocolLib in my plugin so I don't need packetevents to be included.

derklaro commented 9 months ago

I will try to take a look into publishing a version with and one without packetevents shaded soon-ish.

portlek commented 9 months ago

@derklaro you can split the packetevents implementation into another module so people can still use that with adding new module's dependency.

vytskalt commented 9 months ago

Or it could use compileOnly on packetevents and then check at runtime if packetevents is in the classpath. This way it would also be possible to use the standalone packetevents plugin