Streams have very poor overall performance, and are especially rough to use in hot code. Players sneak and Interact constantly, and at scale, usage of streams here was causing up to 1.5% of my server's tick with around 1400+ NPCs in the npcMap.
Simple for-loops are generally best performance. In addition, I reordered the checks to be the most performant (boolean check, then equals check, reserving map lookup for isShownForand finally distance check for last). After these changes, I didn't even see the events show up in my profiler.
In my personal case, we don't even use imitating NPCs, so the best possible performance here would really be to cache into a separate map only the NPCs that imitate, but that might be a micro-optimization for most use cases unless people have thousands and thousands of NPCs.
Streams have very poor overall performance, and are especially rough to use in hot code. Players sneak and Interact constantly, and at scale, usage of streams here was causing up to 1.5% of my server's tick with around 1400+ NPCs in the
npcMap.Simple for-loops are generally best performance. In addition, I reordered the checks to be the most performant (boolean check, then equals check, reserving map lookup for
isShownForand finally distance check for last). After these changes, I didn't even see the events show up in my profiler.In my personal case, we don't even use imitating NPCs, so the best possible performance here would really be to cache into a separate map only the NPCs that imitate, but that might be a micro-optimization for most use cases unless people have thousands and thousands of NPCs.