search

juliarose / backpacktf-api

Interface for backpack.tf API endpoints
MIT License
3 stars 1 forks source link

Handle Marketplace.tf cross listings of craft hats #9

Closed carloslbello closed 1 year ago

carloslbello commented 1 year ago

Marketplace.tf allows listing a variety of craft hats to be listed as 'Random Craft Hat', an item that does not actually exist but that has an SKU of -100;6 (see here). When cross-listed to Backpack.tf the defindex remains as -100 and currently the code for listing snapshots (and probably for listings from the websocket) can't handle it without returning an error.

I think it may be potentially helpful to silently discard these listings, or create a way for the user to opt to handle them in another specific way. Deducing the correct defindex may not always be possible, especially without a copy of the item schema, and (for example) I am not interested in Marketplace.tf cross listings anyway.

Snapshot example:

{"listings":[{"steamid":"76561199059698603","offers":1,"buyout":1,"details":"\u26d4 This item is for sale on Quicksell.store \u26d4 Send me a trade, visit https:\/\/quicksell.store\/buy\/13291873278 or add me and type !buy Bootleg Base Metal Billycock \ud83d\udc4d We're selling more than 9000 items \ud83d\ude09","intent":"sell","timestamp":1690230934,"price":2,"item":{"id":13291873278,"original_id":0,"defindex":30047,"level":68,"quality":6,"inventory":974,"origin":0,"quantity":1,"attributes":[{"defindex":-102,"value":"steam:\/\/rungame\/440\/76561202255233023\/+tf_econ_item_preview%20S76561199059698603A13291873278D7602018237347739101","float_value":0}]},"currencies":{"metal":2},"bump":1690236421,"userAgent":{"lastPulse":1690237372,"client":"-"}},{"steamid":"76561198086824449","offers":1,"buyout":1,"details":"Beep Boop! I am selling my Bootleg Base Metal Billycock for \ud835\udfd0.\ud835\udfcf\ud835\udfcf \ud835\udc2b\ud835\udc1e\ud835\udc1f, I am selling \ud835\udfd0.","intent":"sell","timestamp":1690078805,"price":2.11,"item":{"id":13178812582,"original_id":13024388656,"defindex":30047,"level":17,"quality":6,"inventory":2147485184,"quantity":1,"origin":8,"attributes":[{"defindex":746,"value":1065353216,"float_value":1},{"defindex":292,"value":1115684864,"float_value":64},{"defindex":388,"value":1115684864,"float_value":64}]},"currencies":{"metal":2.11},"bump":1690237379,"userAgent":{"lastPulse":1690237197,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561198082497772","offers":1,"buyout":1,"details":"\u26a1 Selling for \ud835\udfd0.\ud835\udfcf\ud835\udfcf \ud835\udc2b\ud835\udc1e\ud835\udc1f \ud83d\uded2 Send offer or add and type \ud83d\udcac !\ud835\uddef\ud835\ude02\ud835\ude06 Bootleg Base Metal Billycock \ud83d\udcac","intent":"sell","timestamp":1689712965,"price":2.11,"item":{"id":13244452409,"original_id":6801702649,"defindex":30047,"level":43,"quality":6,"inventory":2147486099,"quantity":1,"origin":8,"attributes":[{"defindex":746,"value":1065353216,"float_value":1},{"defindex":292,"value":1115684864,"float_value":64},{"defindex":388,"value":1115684864,"float_value":64}]},"currencies":{"metal":2.11},"bump":1690236733,"userAgent":{"lastPulse":1690237321,"client":"RainTF-Custom-Bot"}},{"steamid":"76561199134023346","offers":1,"buyout":1,"details":"Selling for \ud835\udfee.\ud835\udfed\ud835\udfed \ud835\uddff\ud835\uddf2\ud835\uddf3. Stock: 2 \/ 2 \u26a1 Send an offer or add me and type !buy Bootleg Base Metal Billycock \u26a1","intent":"sell","timestamp":1689697742,"price":2.11,"item":{"id":12660342948,"original_id":11309891190,"defindex":30047,"level":58,"quality":6,"inventory":2147485105,"quantity":1,"origin":8,"attributes":[{"defindex":746,"value":1065353216,"float_value":1},{"defindex":292,"value":1115684864,"float_value":64},{"defindex":388,"value":1115684864,"float_value":64}]},"currencies":{"metal":2.11},"bump":1690236589,"userAgent":{"lastPulse":1690237353,"client":"TF2Autobot - Fastest bot in the planet"}},{"steamid":"76561199211471137","offers":1,"buyout":1,"details":"I am selling my Bootleg Base Metal Billycock for 2.11 ref, I am selling 2.","intent":"sell","timestamp":1689805579,"price":2.11,"item":{"id":12757509112,"original_id":12757299265,"defindex":30047,"level":57,"quality":6,"inventory":2147484839,"quantity":1,"origin":6,"attributes":[{"defindex":746,"value":1065353216,"float_value":1},{"defindex":292,"value":1115684864,"float_value":64},{"defindex":388,"value":1115684864,"float_value":64}]},"currencies":{"metal":2.11},"bump":1690236303,"userAgent":{"lastPulse":1690237173,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561199228865790","offers":1,"buyout":1,"details":"I am selling my Bootleg Base Metal Billycock for 2.11 ref, I am selling 3.","intent":"sell","timestamp":1689201199,"price":2.11,"item":{"id":12948940049,"original_id":3993902900,"defindex":30047,"level":76,"quality":6,"inventory":2147484715,"quantity":1,"origin":8,"attributes":[{"defindex":746,"value":1065353216,"float_value":1},{"defindex":292,"value":1115684864,"float_value":64},{"defindex":388,"value":1115684864,"float_value":64}]},"currencies":{"metal":2.11},"bump":1690236301,"userAgent":{"lastPulse":1690237211,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561197963157650","offers":1,"buyout":1,"details":"\ud83d\udc9c 24\/7 Trading bot \ud83d\udc9c Send a trade offer or add me | \ud835\uddef\ud835\ude02\ud835\ude06_\ud835\uddd5\ud835\uddfc\ud835\uddfc\ud835\ude01\ud835\uddf9\ud835\uddf2\ud835\uddf4_\ud835\uddd5\ud835\uddee\ud835\ude00\ud835\uddf2_\ud835\udde0\ud835\uddf2\ud835\ude01\ud835\uddee\ud835\uddf9_\ud835\uddd5\ud835\uddf6\ud835\uddf9\ud835\uddf9\ud835\ude06\ud835\uddf0\ud835\uddfc\ud835\uddf0\ud835\uddf8 | \ud83d\udcb0 \ud835\udfee.\ud835\udfed\ud835\udfed \ud835\uddff\ud835\uddf2\ud835\uddf3 \ud83d\udcb0 | Stock: 2 \/ 1.","intent":"sell","timestamp":1690236075,"price":2.11,"item":{"id":12766682854,"original_id":12766625448,"defindex":30047,"level":96,"quality":6,"inventory":2147484270,"quantity":1,"origin":8,"attributes":[{"defindex":746,"value":1065353216,"float_value":1},{"defindex":292,"value":1115684864,"float_value":64},{"defindex":388,"value":1115684864,"float_value":64}]},"currencies":{"metal":2.11},"bump":1690236075,"userAgent":{"lastPulse":1690237133,"client":"TF2Autobot - A bot created by Tolfx"}},{"steamid":"76561199220091879","offers":1,"buyout":1,"details":"I am selling my Bootleg Base Metal Billycock for 2.11 ref, I am selling 3.","intent":"sell","timestamp":1689555895,"price":2.11,"item":{"id":13035267747,"original_id":12939618090,"defindex":30047,"level":96,"quality":6,"inventory":2147484667,"quantity":1,"origin":8,"attributes":[{"defindex":746,"value":1065353216,"float_value":1},{"defindex":292,"value":1115684864,"float_value":64},{"defindex":388,"value":1115684864,"float_value":64}]},"currencies":{"metal":2.11},"bump":1690235956,"userAgent":{"lastPulse":1690237299,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561199143431090","offers":1,"buyout":1,"details":"\ud83d\udcb8Selling For \ud835\udfd0.\ud835\udfd0\ud835\udfd0 \ud835\udc2b\ud835\udc1e\ud835\udc1f\ud83d\udcb8, Send Trade. \ud83e\udd71Lazy? Add and Type: !buy Bootleg Base Metal Billycock \ud83d\ude0e 1 \/ 1 \ud83d\udce6","intent":"sell","timestamp":1690221678,"price":2.22,"item":{"id":12935657649,"original_id":1648493226,"defindex":30047,"level":83,"quality":6,"inventory":2147484381,"quantity":1,"origin":8,"attributes":[{"defindex":746,"value":1065353216,"float_value":1},{"defindex":292,"value":1115684864,"float_value":64},{"defindex":388,"value":1115684864,"float_value":64}]},"currencies":{"metal":2.22},"bump":1690236132,"userAgent":{"lastPulse":1690237148,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561198267189538","offers":0,"buyout":0,"details":"Listed on marketplace.tf\/shop\/tf2deals. Do not add me for items worth less than 25 keys - they are only available for cash. Thanks!","intent":"sell","timestamp":1679506625,"price":2.7272727272727275,"item":{"id":12699826945,"original_id":12322085926,"defindex":-100,"level":11,"quality":6,"inventory":0,"quantity":1,"origin":0,"attributes":[{"defindex":746,"value":"1065353216","float_value":1},{"defindex":292,"value":"1115684864","float_value":64},{"defindex":388,"value":"1115684864","float_value":64}],"marketplace_price":0.06,"marketplace_bot_steamid":null,"marketplace_sku":"-100;6"},"currencies":{"usd":0.06},"bump":1690232002,"userAgent":{"lastPulse":1612392329,"client":"python-requests\/2.24.0"}},{"steamid":"76561198267189538","offers":0,"buyout":0,"details":"Listed on marketplace.tf\/shop\/tf2deals. Do not add me for items worth less than 25 keys - they are only available for cash. Thanks!","intent":"sell","timestamp":1679506668,"price":2.7272727272727275,"item":{"id":12672642203,"original_id":12643511472,"defindex":-100,"level":60,"quality":6,"inventory":0,"quantity":1,"origin":0,"attributes":[{"defindex":746,"value":"1065353216","float_value":1},{"defindex":292,"value":"1115684864","float_value":64},{"defindex":388,"value":"1115684864","float_value":64}],"marketplace_price":0.06,"marketplace_bot_steamid":null,"marketplace_sku":"-100;6"},"currencies":{"usd":0.06},"bump":1690232002,"userAgent":{"lastPulse":1612392329,"client":"python-requests\/2.24.0"}},{"steamid":"76561198267189538","offers":0,"buyout":0,"details":"Listed on marketplace.tf\/shop\/tf2deals. Do not add me for items worth less than 25 keys - they are only available for cash. Thanks!","intent":"sell","timestamp":1679680394,"price":2.7272727272727275,"item":{"id":12723886874,"original_id":12671349708,"defindex":-100,"level":31,"quality":6,"inventory":0,"quantity":1,"origin":0,"attributes":[{"defindex":746,"value":"1065353216","float_value":1},{"defindex":292,"value":"1115684864","float_value":64},{"defindex":388,"value":"1115684864","float_value":64}],"marketplace_price":0.06,"marketplace_bot_steamid":null,"marketplace_sku":"-100;6"},"currencies":{"usd":0.06},"bump":1690232002,"userAgent":{"lastPulse":1612392329,"client":"python-requests\/2.24.0"}},{"steamid":"76561198267189538","offers":0,"buyout":0,"details":"Listed on marketplace.tf\/shop\/tf2deals. Do not add me for items worth less than 25 keys - they are only available for cash. Thanks!","intent":"sell","timestamp":1681029972,"price":2.7272727272727275,"item":{"id":12776031959,"original_id":12443610522,"defindex":-100,"level":13,"quality":6,"inventory":0,"quantity":1,"origin":0,"attributes":[{"defindex":746,"value":"1065353216","float_value":1},{"defindex":292,"value":"1115684864","float_value":64},{"defindex":388,"value":"1115684864","float_value":64}],"marketplace_price":0.06,"marketplace_bot_steamid":null,"marketplace_sku":"-100;6"},"currencies":{"usd":0.06},"bump":1690232002,"userAgent":{"lastPulse":1612392329,"client":"python-requests\/2.24.0"}},{"steamid":"76561198267189538","offers":0,"buyout":0,"details":"Listed on marketplace.tf\/shop\/tf2deals. Do not add me for items worth less than 25 keys - they are only available for cash. Thanks!","intent":"sell","timestamp":1682706335,"price":2.7272727272727275,"item":{"id":12964920655,"original_id":10731944859,"defindex":-100,"level":90,"quality":6,"inventory":0,"quantity":1,"origin":0,"attributes":[{"defindex":746,"value":"1065353216","float_value":1},{"defindex":292,"value":"1115684864","float_value":64},{"defindex":388,"value":"1115684864","float_value":64}],"marketplace_price":0.06,"marketplace_bot_steamid":null,"marketplace_sku":"-100;6"},"currencies":{"usd":0.06},"bump":1690232002,"userAgent":{"lastPulse":1612392329,"client":"python-requests\/2.24.0"}},{"steamid":"76561198267189538","offers":0,"buyout":0,"details":"Listed on marketplace.tf\/shop\/tf2deals. Do not add me for items worth less than 25 keys - they are only available for cash. Thanks!","intent":"sell","timestamp":1684513600,"price":2.7272727272727275,"item":{"id":13051371760,"original_id":9892638171,"defindex":-100,"level":11,"quality":6,"inventory":0,"quantity":1,"origin":0,"attributes":[{"defindex":746,"value":"1065353216","float_value":1},{"defindex":292,"value":"1115684864","float_value":64},{"defindex":388,"value":"1115684864","float_value":64}],"marketplace_price":0.06,"marketplace_bot_steamid":null,"marketplace_sku":"-100;6"},"currencies":{"usd":0.06},"bump":1690232002,"userAgent":{"lastPulse":1612392329,"client":"python-requests\/2.24.0"}},{"steamid":"76561198267189538","offers":0,"buyout":0,"details":"Listed on marketplace.tf\/shop\/tf2deals. Do not add me for items worth less than 25 keys - they are only available for cash. Thanks!","intent":"sell","timestamp":1686864943,"price":2.7272727272727275,"item":{"id":13150650768,"original_id":12986380580,"defindex":-100,"level":55,"quality":6,"inventory":0,"quantity":1,"origin":0,"attributes":[{"defindex":746,"value":"1065353216","float_value":1},{"defindex":292,"value":"1115684864","float_value":64},{"defindex":388,"value":"1115684864","float_value":64}],"marketplace_price":0.06,"marketplace_bot_steamid":null,"marketplace_sku":"-100;6"},"currencies":{"usd":0.06},"bump":1690232002,"userAgent":{"lastPulse":1612392329,"client":"python-requests\/2.24.0"}},{"steamid":"76561198380634252","offers":1,"buyout":0,"details":"buying SPELL QUICKSELLS, prices can vary per SPELL, can get more keys, and can buy other SPELL QUICKSELLS too!","intent":"buy","timestamp":1685128006,"price":797.1500000000001,"item":{"defindex":30047,"quality":6,"attributes":[{"float_value":"2","defindex":"1005"},{"float_value":"1","defindex":"1004"},{"value":null,"defindex":229}],"quantity":"1"},"currencies":{"keys":10},"bump":1690236081},{"steamid":"76561198885993611","offers":1,"buyout":0,"details":"\ud83c\udf83VFB-1 key\ud83c\udf83\n\ud83c\udf83SS, DJ, PP- 2 keys\ud83c\udf83\n\ud83c\udf83Spectra, CC- 2keys\ud83c\udf83\nWilling to do pay more for \ud83c\udf83doublespelled or FP\ud83c\udf83 Also buying any other spelled item (price might be different)","intent":"buy","timestamp":1690226286,"price":398.57500000000005,"item":{"defindex":30047,"quality":6,"attributes":[{"defindex":"1006"},{"float_value":"2","defindex":"1005"},{"value":null,"defindex":229}],"quantity":"1"},"currencies":{"keys":5},"bump":1690234391},{"steamid":"76561198110912705","offers":1,"buyout":0,"details":"\u2800\u2800\u26abBLACK 14 REF \ud83c\udf80PINK 14 REF \ud83d\udfe2LIME 14 REF \u2800\u2800\u2800\u26aaWHITE 14 REF \ud83d\udfe3PURPLE 3 REF \ud83d\udfe1GOLD 3 REF \u2800\u2800\u2800\u26abAFTER8 8 REF \ud83d\udd34ValueOTW 7 REF \ud83d\udd35TS 8 REF \u2800 \u2800\u2800\u2800\u2800 \u2800\u2800\u2800\u2800\u2800\u2800\u2666\ufe0f \ud835\udc12\ud835\udc04\ud835\udc0d\ud835\udc03 \ud835\udc0c\ud835\udc04 \ud835\udc00 \ud835\udc13\ud835\udc11\ud835\udc00\ud835\udc03\ud835\udc04 \ud835\udc0e\ud835\udc05\ud835\udc05\ud835\udc04\ud835\udc11 \u2666\ufe0f","intent":"buy","timestamp":1690189755,"price":14,"item":{"defindex":30047,"quality":6,"attributes":[{"float_value":"1315860","defindex":"142"},{"value":null,"defindex":229}],"quantity":"1"},"currencies":{"metal":14},"bump":1690223305,"userAgent":{"lastPulse":1689464245,"client":"axios\/0.15.3"}},{"steamid":"76561198274855163","offers":1,"buyout":1,"details":"\u26ab BLACK: 13 REF \ud83c\udf80 PINK: 13 REF \ud83d\udfe2 LIME: 13 REF \u26aa WHITE: 13 REF \ud83d\udd35 TEAM SPIRIT: 8 REF \u26d4 Buying these for MORE $ and INSTANTLY \u26a1\ufe0f [24\/7] visit: PAINTEDHATS.TF \u26d4","intent":"buy","timestamp":1683479448,"price":13,"item":{"defindex":30047,"quality":6,"attributes":[{"float_value":"1315860","defindex":"142"},{"value":null,"defindex":229}],"quantity":"1"},"currencies":{"metal":13},"bump":1690225169,"userAgent":{"lastPulse":1672305320,"client":"Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/108.0.0.0 Safari\/537.36"}},{"steamid":"76561198082497772","offers":1,"buyout":1,"details":"\u26a1 Buying for \ud835\udfd0 \ud835\udc2b\ud835\udc1e\ud835\udc1f \ud83d\uded2 Maximum Stock: 3 \u2666\ufe0f Send offer or add and type \ud83d\udcac !\ud835\ude00\ud835\uddf2\ud835\uddf9\ud835\uddf9 Bootleg Base Metal Billycock \ud83d\udcac","intent":"buy","timestamp":1690027777,"price":2,"item":{"defindex":30047,"quality":6},"currencies":{"metal":2},"bump":1690236733,"userAgent":{"lastPulse":1690237321,"client":"RainTF-Custom-Bot"}},{"steamid":"76561199498341984","offers":1,"buyout":1,"details":"I am buying your Bootleg Base Metal Billycock for \ud835\udfd0 \ud835\udc2b\ud835\udc1e\ud835\udc1f, I have 0 \/ 1. Do !sell Bootleg Base Metal Billycock.","intent":"buy","timestamp":1690171673,"price":2,"item":{"defindex":30047,"quality":6,"attributes":[{"value":null,"defindex":229}]},"currencies":{"metal":2},"bump":1690236719,"userAgent":{"lastPulse":1690237138,"client":"TF2Autobot - TF2Autobot - Jeff"}},{"steamid":"76561199339144555","offers":1,"buyout":1,"details":"I am buying your Bootleg Base Metal Billycock for 2 ref, I have 0 \/ 1. For easy trade add me and type in chat !sell Bootleg Base Metal Billycock.","intent":"buy","timestamp":1690158943,"price":2,"item":{"defindex":30047,"quality":6,"attributes":[{"value":null,"defindex":229}]},"currencies":{"metal":2},"bump":1690236488,"userAgent":{"lastPulse":1690237208,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561198141964860","offers":1,"buyout":1,"details":"\u26a1 Buying for \ud835\udfd0 \ud835\udc2b\ud835\udc1e\ud835\udc1f \ud83d\uded2 Maximum Stock: 3 \u2666\ufe0f Send offer or add and type \ud83d\udcac !\ud835\ude00\ud835\uddf2\ud835\uddf9\ud835\uddf9 Bootleg Base Metal Billycock \ud83d\udcac","intent":"buy","timestamp":1690028068,"price":2,"item":{"defindex":30047,"quality":6},"currencies":{"metal":2},"bump":1690236425,"userAgent":{"lastPulse":1690237323,"client":"RainTF-Custom-Bot"}},{"steamid":"76561199211471137","offers":1,"buyout":1,"details":"I am buying your Bootleg Base Metal Billycock for 2 ref, I have 2 \/ 3.","intent":"buy","timestamp":1689805579,"price":2,"item":{"defindex":30047,"quality":6,"attributes":[{"value":null,"defindex":229}]},"currencies":{"metal":2},"bump":1690236363,"userAgent":{"lastPulse":1690237173,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561199518240485","offers":1,"buyout":1,"details":"Buying this item for \ud835\udfd0 \ud835\udc2b\ud835\udc1e\ud835\udc1f, stock 0 \/ 1. !sell 1 Bootleg Base Metal Billycock or send an offer. MP shop -> https:\/\/mplc.tf\/s\/tf2deals","intent":"buy","timestamp":1690212672,"price":2,"item":{"defindex":30047,"quality":6,"attributes":[{"value":null,"defindex":229}]},"currencies":{"metal":2},"bump":1690236128,"userAgent":{"lastPulse":1690237326,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561198341363946","offers":1,"buyout":1,"details":"\u2708\ufe0f24\/7 BOT!\u26a1 Buying Bootleg Base Metal Billycock for \ud835\udfd0 \ud835\udc2b\ud835\udc1e\ud835\udc1f. I can buy 1! To sell send me a trade offer or add and type !sell Bootleg Base Metal Billycock","intent":"buy","timestamp":1690222209,"price":2,"item":{"defindex":30047,"quality":6,"attributes":[{"value":null,"defindex":229}]},"currencies":{"metal":2},"bump":1690235722,"userAgent":{"lastPulse":1690237342,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561198194247990","offers":1,"buyout":1,"details":"Buying anything for the right price! I'm buying 1 of this thing for 2 ref each. Add me and type \"!sell Bootleg Base Metal Billycock\"","intent":"buy","timestamp":1690155511,"price":2,"item":{"defindex":30047,"quality":6,"attributes":[{"value":null,"defindex":229}]},"currencies":{"metal":2},"bump":1690235635,"userAgent":{"lastPulse":1690237194,"client":"TF2Autobot - Run your own bot for free"}},{"steamid":"76561198843036728","offers":1,"buyout":1,"details":"Shalom!~\ud83c\udf39 I'm buying for 2 ref \ud83d\udce6(0\/1)\ud83d\udce6 Items offers\/trade holds welcome! \ud83e\udd40 Send a trade offer or add me and type \"!sell Bootleg Base Metal Billycock\" Thank you! \u2764\ufe0f","intent":"buy","timestamp":1690206088,"price":2,"item":{"defindex":30047,"quality":6,"attributes":[{"value":null,"defindex":229}]},"currencies":{"metal":2},"bump":1690234889,"userAgent":{"lastPulse":1690237410,"client":"TF2Autobot - Run your own bot for free"}}],"appid":440,"sku":"Bootleg Base Metal Billycock","createdAt":1690237419}

Error example:

Error: Parse(Error("invalid value: integer `-100`, expected u32", line: 1, column: 6360))
juliarose commented 1 year ago

I suspected it could end up being an issue with marketplace SKUs. I don't see a good way around this but to use an i32.

I've changed the integer type to i32 in https://github.com/juliarose/backpacktf-api/commit/ad68f3d77eef49039cfce40ef1e69ad49f512de1