search

juliasilge / supervised-ML-case-studies-course

Supervised machine learning case studies in R! 💫 A free interactive tidymodels course
https://supervised-ml-course.netlify.app/
MIT License
222 stars 76 forks source link

Chapter 4, Exercise 13: xgboost performing better than GBM #31

Closed johncassil closed 5 years ago

johncassil commented 5 years ago

Hey Julia!

THANK YOU SO MUCH for an amazing course. I have been impressed end to end and I am definitely going to share it with a bunch of folks.

I got tripped up on something and wanted to see if it's a mistake, maybe with the saved model RDS, or updated default parameters.

In Chapter 4, Exercise 13, the rmse for the xgboost predictions (12.3472006) is smaller than the rmse for GBM predictions (12.4721538), but the lesson goes on to say that GBM performed the best.

You can test by going to https://supervised-ml-course.netlify.com/chapter4 in incognito mode, click "Show solution" and "Run Code":

input output

Please let me know if I can help with a fix!

juliasilge commented 5 years ago

Thank you so much for this report @johncassil! 🙌 I appreciate it a lot.

I believe I have found all the places/ways this needs to be edited/corrected, but certainly if you noticed anything else, please let me know.