search

juliasilge / widyr

Widen, process, and re-tidy a dataset
http://juliasilge.github.io/widyr/
Other
327 stars 29 forks source link

Force install some dependency packages on AppVeyor #3

Closed juliasilge closed 8 years ago

juliasilge commented 8 years ago

I ran into this problem for builds on AppVeyor for tidytext, as discussed in https://github.com/krlmlr/r-appveyor/issues/69. The new version of devtools is having a problem with installing the dependencies of dependencies on Windows builds, it seems like. You can get the package to build by forcing it to install packages that have dependencies before install_deps. I think I got them all here by looking at DESCRIPTION and CRAN websites but it's possible there will be another one or two; I'll check if AppVeyor fails again.

codecov-io commented 8 years ago

Current coverage is 74.34%

Merging #3 into master will not change coverage

@@             master         #3   diff @@
==========================================
  Files             7          7          
  Lines           152        152          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            113        113          
  Misses           39         39          
  Partials          0          0

Powered by Codecov. Last updated by ba460c1...d8229ea

blosloos commented 8 years ago

This can hardly be a solution, e.g., what if the Depends of Depends change? Unfortunately, there seems no work-around for automatizing a recursive check for all dependencies to be installed ahead of running install_github.

juliasilge commented 8 years ago

Yep, sure. This PR would just be a temporary fix until the underlying problem in devtools is fixed. There hadn't been any references to that issue in a couple of weeks, which is why I did the PR, but it looks like there may have been a fix this morning? If AppVeyor starts using the GitHub version of devtools this may all be a moot point, which would be wonderful news indeed.

blosloos commented 8 years ago

The problem seems solved in the latest devtools version, just checked that. Its remarkable it has been seemingly there for while - I would have expected more people depending (ha!) on a clean install from github...

juliasilge commented 8 years ago

The development version of devtools is working on appveyor now 👍🏻 so I'm closing this PR!

blosloos commented 8 years ago

There seems to be a new problem with install_github, and I wonder hereby if it is reproducible in other R sessions than mine. Could please someone try in R: 

install.packages("devtools")
library(devtools)
install_github("hadley/devtools")

Thanks in advance ...

juliasilge commented 8 years ago

@blosloos I just tried that and it all ran fine for me on OSX, R 3.3.1. It installed devtools from CRAN, then from GitHub.

blosloos commented 8 years ago

@juliasilge Thank you very much for trying this, juliasilge! I repeated the same after reinstalling R 3.3.1 and it worked fine, too. However, this time dependencies were all installed into a personal library after a Win10 (arrrrg) update, instead of the regular R library, as compared to before the update. A mixture of R vs. personal libraries after the Win update but before reinstalling R might have resulted in errors; and total confusion for devtools?