Code cleanup - Githubissues

juliema / label_reconciliations

Code for reconciling multiple transcriptions for a label

MIT License

26 stars 11 forks source link

Code cleanup #12

Closed rafelafrance closed 7 years ago

rafelafrance commented 7 years ago

[x] Don't use a single string to hold the best values and flags. Use either a named tuple instead or json.
[ ] Possibly use the luigi module?
[x] Remove lingering magic constants
[ ] Reduce number of data frames used
[x] Change sorts to use tuple keys

rafelafrance commented 7 years ago

Adding a new item:

Reduce the number of data frames used. The original code was trying to splice out data in various ways. This turned out to be unhelpful. The lingering code still has the excess data frames in it.

rafelafrance commented 7 years ago

Adding a new item:

Use tuples as keys for the sort arrays

rafelafrance commented 7 years ago

Hold off on the Luigi module for now
Hold off on the data frame count refactor until we get user feedback on the output