search

julien-c / epub

node.js epub reader
https://www.npmjs.com/package/epub
Other
333 stars 307 forks source link

update xml2js to 0.4.4 #12

Closed mawi12345 closed 9 years ago

mawi12345 commented 9 years ago

A lot of issues have been fixed since 0.1. For example the annoying BOM errors.

julien-c commented 9 years ago

I'll merge this, but I'd rather we use the new standard xml2js settings if we upgrade it, what do you think?

See also #7

mawi12345 commented 9 years ago

I think it would be great to refactor the whole lib to use the new xml2js object created by the default options. But for now the lib works great and the change might introduce new issues.

This big refactoring should be on the roadmap to 0.2.