julien-c / epub

node.js epub reader
https://www.npmjs.com/package/epub
Other
333 stars 307 forks source link

Move zipfile to peerDependencies #51

Open xamgore opened 4 years ago

xamgore commented 4 years ago

npm install also installs optional dependencies, zipfile in case of epub package. I suggest moving it to peerDependencies.

At the moment node-gyp is called to compile zipfile on macOS Catalina, Node 13/14, fails, and prints a huge error stack in the log. Every time I call npm install. It can be fixed with npm set optional false, but...