search

julien-c / epub

node.js epub reader
https://www.npmjs.com/package/epub
Other
331 stars 308 forks source link

Upgrade xml2js? #7

Open julien-c opened 10 years ago

julien-c commented 10 years ago

Hi,

Would you be willing to accept a PR upgrading xml2js? Semantics have changed and I find it strenuous to refer to an old version of the documentation.

Cheers!

Julien

andris9 commented 10 years ago

Yeah, sure.

I'm not actively maintaining this repo, so maybe you would be interested taking over this project? I can give you control over the npm epub package and add a link to the readme pointing to your repo. Interested?

julien-c commented 10 years ago

I might be interested, let me think about it as it's quite the commitment :)

Do you know of anyone using it in production?

andris9 commented 10 years ago

No, i do not know anyone using it. Actully I hadn't touched this repo for 3 years before you created your first pull request.

julien-c commented 10 years ago

Ok, let's do it then!

andris9 commented 10 years ago

Ok, could you tell me your npm username, so I could add the admin rights and could you delete your existing epub fork from your github account, so I could initiate a repo transfer from my account to yours (a repo can't be transfered if the receiving user already has a repo with the same name or an existing fork of the transferred repo).

andris9 commented 10 years ago

Tranferring a repo is better than "deprecting" it and linking to a fork as in this case all the "stars" and "watchers" will move to the new repo automatically.

julien-c commented 10 years ago 
$ npm whoami
julien-c

I deleted both my fork and my (unrelated) epub repo.

Thanks!

andris9 commented 10 years ago

I added your user as the epub module owner. You're now able to modify and publish the updates as you will!

$ npm owner ls
npm http GET https://registry.npmjs.org/epub
npm http 200 https://registry.npmjs.org/epub
andris <****@****>
julien-c <****@****>
julien-c commented 10 years ago

Great, cheers!