search

julien-c / iso3166

ISO 3166-1 alpha-2 mapping
65 stars 9 forks source link

Update Codes.php #4

Closed nimasdj closed 8 years ago

nimasdj commented 8 years ago

This array is too much more complete around 10 countries more than previous one. for sure you can compare your first array with this one https://gist.github.com/vxnick/380904#gistcomment-1433576 Also it should return the original code if not found.

nimasdj commented 8 years ago

@julien-c When will you merge it and release a version? This repo is still maintained?

julien-c commented 8 years ago

Please fix indentation, thanks

On Saturday, December 12, 2015, nimasdj notifications@github.com wrote:

@julien-c https://github.com/julien-c When will you merge it and release a version? This repo is still maintained?

— Reply to this email directly or view it on GitHub https://github.com/julien-c/iso3166/pull/4#issuecomment-164117606.

nimasdj commented 8 years ago

@julien-c I did fix indentation, please merge it and release a new version as we need to install it via Composer asap.

julien-c commented 8 years ago

Merged. Do you want me to add you as contributor? That way you can tag the release yourself.

nimasdj commented 8 years ago

@julien-c if you don't have time to release a new version, then yes, you might want to add me as contributor that I would release a new version. But please note that in future, I would not take any action here without letting you know before, even if you make me as a cotributor.

nimasdj commented 8 years ago

@julien-c Sorry, I see new release is not affected on packagist, I renamed 1.2.0 to v1.2.0 and not yet affected please check why it is not affected on packagist?

julien-c commented 8 years ago

So, first of all, I've just set up the Github repo and Packagist account so that the Packagist distribution is auto-updated from now on.

nimasdj commented 8 years ago

I disvcovered the issue. It was because you had version in composer.json, I removed it from composer.json and re-released the version, now it is on packagist. You should not add version in composer.json.

julien-c commented 8 years ago

Yep. 1.2.0 is on Packagist now. Cheers

nimasdj commented 8 years ago

I also edited old versions and removed leading "v" from tags. You should not have leading "v" nor a version in composer.json, now I fixed everything.

julien-c commented 8 years ago

Ok, but in theory you shouldn't rewrite existing tags (like 1.1.0) as it might change stuff for existing users of the library.

nimasdj commented 8 years ago

Ok, you have reason, but nothing dangerous will happen to them, may be just will be re-updated for them without any coding break. But I keep it in mind in future. :-)