drop port forwarding and give names to magic variables

julien-duponchelle / docker-osx

Fast and easy installation of Docker on OS X

1.02k stars 70 forks source link

drop port forwarding and give names to magic variables #22

Closed mmerickel closed 10 years ago

mmerickel commented 10 years ago

I'm not great with bash scripting so I opted to avoid trying to merge environment vars into the config, but at least they have explicit names for anyone copying the file.

mmerickel commented 10 years ago

side note, it looks like FORWARD_DOCKER_PORTS isn't used for anything right now

julien-duponchelle commented 10 years ago

I just drop FORWARD_DOCKER_PORTS thanks

mmerickel commented 10 years ago

If you'd like me to rebase this onto #24 let me know.

julien-duponchelle commented 10 years ago

Merged :) I also add the configuration of port