julien-duponchelle / python-mysql-replication

Pure Python Implementation of MySQL replication protocol build on top of PyMYSQL
2.33k stars 679 forks source link

Remove python2 and mysql5.7 code #515

Closed mirageoasis closed 1 year ago

mirageoasis commented 1 year ago

while looking around repository I came across python2, mysql 5.7 tests, codes and Github Actions which was deprecated in python-mysql-replication version 1.0

However, I think there should be some improvement over config.json and docker-compse.yml

Since config.json port setting depends on docker-compose file.

mirageoasis commented 1 year ago

If you delete all mysql 5.7 version Test it would be better set global variable binlog_row_metadata = "FULL" in setUp method.

understood I will apply this in following commit

dongwook-chan commented 1 year ago

We cannot overlook the MySQL 5.7 user base. I know MySQL declared EOL for 5.7 but there are plenty of users that can benefit from the code.