refactor: check 'is_mariadb' when trying to set 'mariadb-related variable(mariadb_slave_capability)' to master

julien-duponchelle / python-mysql-replication

Pure Python Implementation of MySQL replication protocol build on top of PyMYSQL

2.33k stars 679 forks source link

refactor: check 'is_mariadb' when trying to set 'mariadb-related variable(mariadb_slave_capability)' to master #559

Open ebang091 opened 1 year ago

ebang091 commented 1 year ago

thought codes below needs check whether the master is mariaDB or not.

before

after

dongwook-chan commented 1 year ago

Because not all tests were functional at the point of this PR. I will run some tests manually before merging this to main. Could you wait just a bit more?