search

julien-duponchelle / python-mysql-replication

Pure Python Implementation of MySQL replication protocol build on top of PyMYSQL
2.31k stars 678 forks source link

Fix missing charset setting in base.py #564

Closed starcat37 closed 11 months ago

starcat37 commented 11 months ago

Issue Description and Solution

The TestLatin1 test is currently failing and has therefore been excluded from the actual pytest run. Upon investigation, it appears that the charset setting (db["charset"] = charset) has been omitted in base.py.

https://github.com/julien-duponchelle/python-mysql-replication/blob/b542936378c715e49137b23369fc5c15699c2b9a/pymysqlreplication/tests/base.py#L45-L58

I plan to add the missing charset setting and re-include the test_query_event_latin1 test in the pytest suite.

Special thanks to @sean-k1 for the assistance😄

starcat37 commented 11 months ago

Closed by PR #565