search

julien-duponchelle / python-mysql-replication

Pure Python Implementation of MySQL replication protocol build on top of PyMYSQL
2.31k stars 678 forks source link

Add omitted charset setting in base.py #565

Closed starcat37 closed 11 months ago

starcat37 commented 11 months ago

Description

This pull request addresses Issue #564.

To resolve the failing TestLatin1 test, I have added the line db["charset"] = charset to base.py.

As a result of this change, the charset setting now functions correctly in the TestLatin1 test.

https://github.com/julien-duponchelle/python-mysql-replication/blob/1d2c8aba5d96ca4573054e51038d9f62b43da9e9/pymysqlreplication/tests/test_basic.py#L1474-L1476

With this fix in place, I have also re-included the test_query_event_latin1 test in the pytest suite, as it now passes successfully.