[readme] mysql-server-settings part has a deprecated variable

julien-duponchelle / python-mysql-replication

Pure Python Implementation of MySQL replication protocol build on top of PyMYSQL

2.31k stars 678 forks source link

[readme] mysql-server-settings part has a deprecated variable #577

Closed gongyisheng closed 9 months ago

gongyisheng commented 10 months ago

Hi, I'm setting up binlog subscription using this package and I notice that the mysql-server-settings part contains a deprecated variable.

mysql version: >8.0

Quote from mysql doc:

expire_logs_days is deprecated, and you should expect it to be removed in a future release. Instead, use binlog_expire_logs_seconds, which sets the binary log expiration period in seconds.

sean-k1 commented 10 months ago

@gongyisheng Hello Thanks for reporting

Cool I think it would be good to fix the readme with binlog_expire_log_seconds, which has been replaced since Mysql 8.0.

Would you be willing to work on this issue?

gongyisheng commented 10 months ago

Hi @sean-k1, sure, I can help submit a PR to fix it.

sean-k1 commented 10 months ago

@gongyisheng I assgined you thnaks!