test dump method in test_delete_row_event

julien-duponchelle / python-mysql-replication

Pure Python Implementation of MySQL replication protocol build on top of PyMYSQL

2.31k stars 678 forks source link

test dump method in test_delete_row_event #592

Closed roy0424 closed 9 months ago

roy0424 commented 9 months ago

Description

Type of Change

[ ] Bug fix
[ ] New feature
[ ] Documentation update
[x] Other (add test dump method)

Checklist

[x] I have read and understood the CONTRIBUTING.md document.
[x] I have checked there aren't any other open Pull Requests for the desired changes.
[ ] This PR resolves an issue #[Issue Number Here].

Tests

[x] All tests have passed.
[x] New tests have been added to cover the changes. (describe below if applicable).

Additional Information

sean-k1 commented 9 months ago

@roy0424 The user var event is the user entering the value directly, so I think the mock test makes sense, but the I don't understand why the delete event generates a separate mock event. I think this is just comparing the same IO occurrences. Is there any particular reason?

roy0424 commented 9 months ago

@sean-k1 I made it to improve coverage. But I realized that this test was unnecessary