julien-duponchelle / python-mysql-replication

Pure Python Implementation of MySQL replication protocol build on top of PyMYSQL
2.31k stars 678 forks source link

Bug in f-string formatting #614

Closed AdrienPensart closed 5 months ago

AdrienPensart commented 5 months ago

In the last version, there is an issue introduced here :

https://github.com/julien-duponchelle/python-mysql-replication/commit/0e31c58815f8c03b1eb93d9519ab71fc4268c8e9

Those slave_uuid should be quoted ! Or else, replication events like this SET will crash the loop stream.

julien-duponchelle commented 5 months ago

Thanks , are you happy to provide a PR?

AdrienPensart commented 5 months ago

Of course ;)

https://github.com/julien-duponchelle/python-mysql-replication/pull/615

sean-k1 commented 5 months ago

@AdrienPensart could you make pr for this issue

julien-duponchelle commented 5 months ago

Thanks a lot fix merged and released