search

julien-maurel / jQuery-Storage-API

This plugin is no longer maintained! A new one, without dependencies with jQuery, is available : https://github.com/julien-maurel/js-storage
308 stars 83 forks source link

Uncaught TypeError: Cannot read property 'setItem' of undefined #31

Closed dutsik closed 8 years ago

dutsik commented 8 years ago

when including a page into Facebook as an iframe the plugin throws an exception:

You can check it here:

  1. https://www.facebook.com/myxtramile/?sk=app_822422207880350
  2. press Postuler

and the orginal which is working just fine:

  1. https://adutskevich.com/landings/myxtramile/
  2. press Postuler

Looks like there is a problem with nesting frame

julien-maurel commented 8 years ago

what browser do you use? i try your link on ff and chrome, i have no issue. and i ran tests (Jasmine/SpecRunner.html) by including this page in an iframe and no issue too

dutsik commented 8 years ago

You are absolutelly right it looks like all is fine in FF. The issue is in chrome, Version 53.0.2785.116 m. See the screenshot below.

image

julien-maurel commented 8 years ago

Exactly same version of chrome and no issue/log when I click...

dutsik commented 8 years ago

Ok, I found the issue.

I set to block 3rd party cookies in chrome, so it is likely that your plugin fails when there is no possibility to create a cookie storage or smth. Anyway, thanks for your time. Now i know that all is almost working ;) Screenshot is attached. image

julien-maurel commented 8 years ago

yw