julien-nc / cospend-nc

💰 💲hared budget manager Nextcloud app
GNU Affero General Public License v3.0
238 stars 29 forks source link

Comma support in currency/"How much?" field #111

Open BloodyIron opened 2 years ago

BloodyIron commented 2 years ago

Can we please get the "How much?"/currency field to support commas? When I put in 1,523.98, for example, it refuses to accept the value as the comma is unsupported in the value. Not exactly high priority, but commas are frequent when dealing with currency and such.

BloodyIron commented 2 years ago

Any chance we can get this added please?

julien-nc commented 2 years ago

It might be common to display numbers like that but not to accept that as a number format in an input field. In Cospend, the numeric fields support the comma and the dot as the float separator. It would not be trivial to keep that and add support for 1,523.98 Sorry, I don't think it will be added. Unless you convince me :wink:.

BloodyIron commented 11 months ago

Surely I'm not the first in the history of the internet to want to use a comma and a period for a currency input value and have that not break input sanitation. Isn't there a PHP function for this? (I wouldn't really know which method is best for this, but commas in currency input is extremely commonplace around the world). I still really would want to see this feature added and it gets in my way plenty still (to this day). So if that could get put in, that would be appreciated. :)