search

julien-nc / cospend-nc

💰 💲hared budget manager Nextcloud app
GNU Affero General Public License v3.0
213 stars 29 forks source link

Archive projects #236

Closed j0hannesr0th closed 7 months ago

j0hannesr0th commented 7 months ago

Hi @julien-nc, I've implemented the functionality for archiving projects and unarchiving them.

You can view the functionality here:

https://github.com/julien-nc/cospend-nc/assets/36242595/306b02a3-2fdb-4510-a267-dd2d0d58d048

To identify which project is archived I've used DateTime. I want to show when the project was archived soon.

In the near future, I plan to add:

Fixes: #128

j0hannesr0th commented 7 months ago

@julien-nc did some more cosmetic stuff... now you can test it.

j0hannesr0th commented 7 months ago

Super nice! Thanks a lot for the PR. 💙 Sorry I have a lot of change requests. I made suggestions for most of them. Mainly:

  • I think we should use a timestamp to store the archived date

Ok

  • The mixin does not work, let's go with an event to trigger a call to the deselectProject method in App

Ah, some comments where hidden...

Do I need to do something? 😅

julien-nc commented 7 months ago

Do I need to do something?

What do you mean? :grin:

j0hannesr0th commented 7 months ago

Do I need to do something?

What do you mean? 😁

I'm not sure what I have to do now ^^ I accepted all your changes and commited them. Is there something left to do for me?

j0hannesr0th commented 7 months ago

I can also push some commits in your branch, as you wish.

Then you should probably finish it. Next time I'll ask/discuss beforehand how to resolve the problem (like using timestamp instead of datetime) to not play ping pong.

julien-nc commented 7 months ago

Alright, thanks for being open to my suggestions.