julien-nc / cospend-nc

💰 💲hared budget manager Nextcloud app
GNU Affero General Public License v3.0
213 stars 29 forks source link

Wrong rendering of avatars in Safari #262

Closed LouisFaure closed 4 months ago

LouisFaure commented 4 months ago

Salut @julien-nc !

I noticed that in Safari, both coloured and image avatars are wrongly rendered: Screenshot 2024-03-03 at 12 05 53

The coloured avatar is stretched two times over the height of its parent div, and the image is moved right below its parent div.

I could recover this by adding the css properties:

Doing these two changes lead to a better result, but there are still the bullets points showing next to each first lines, something I am not seeing on other browsers: Screenshot 2024-03-03 at 12 14 15

julien-nc commented 4 months ago

@LouisFaure Thanks for the issue. As you know, apple makes it difficult to use safari if you don't buy a device from them. I don't want to spend to much effort on supporting this browser.

I included your suggested changes and adjusted to make sure it does not break the style on Firefox and Chromium. Could you try those changes in safari? https://github.com/julien-nc/cospend-nc/commit/23fa9d133b3ef54559594b58b78434ce4d2fdb70

LouisFaure commented 4 months ago

Just tested on Safari in development mode and now everything renders well! (Chrome and Firefox are unaffected)

julien-nc commented 4 months ago

Nice, thanks for checking! This will be included in the next release.