Field "Repeat" - add more options

julien-nc / cospend-nc

💰 💲hared budget manager Nextcloud app

GNU Affero General Public License v3.0

238 stars 29 forks source link

Field "Repeat" - add more options #47

Open pawlosck opened 3 years ago

pawlosck commented 3 years ago

Could you add other options into field "Repeat"?

Repeat transfer every specific number of days/weeks/months etc. For example 30 days (real case from my country)
Repeat transfer, but only in work days. For example. Repeat transfer every 30 days, but when next transfer will be at weekend or at holidays (New Year's day, Christmas, Independence Day etc), make transfer in last work day before holiday, or at first work day after holiday. Should be option to specific it.

julien-nc commented 3 years ago

Hey, both points are interesting but the second is quite sketchy or complicated. Holidays have to be defined somewhere. I like the idea but I don't have time to do it.

is done and available in latest nightly build (v1.3.2-1-nightly).There is a new field called frequency in bill edition form. Could you give it a try? You can create a bill in the past, then set a custom repetition and press "Repeat now" to make some tests.

pawlosck commented 3 years ago

Hi. I will check it later. Holidays are displayed in korganizer app (it's calendar for KDE (Linux)). App is opensource, so probably you can use these files. https://github.com/KDE/kholidays/tree/master/holidays/plan2

pawlosck commented 3 years ago

Hey, both points are interesting but the second is quite sketchy or complicated. Holidays have to be defined somewhere. I like the idea but I don't have time to do it.
1. is done and available in latest nightly build (v1.3.2-1-nightly).There is a new field called frequency in bill edition form. Could you give it a try? You can create a bill in the past, then set a custom repetition and press "Repeat now" to make some tests.
Tested and it works.

PS. Did you check these files with holidays?

julien-nc commented 3 years ago

Tested and it works.

Thanks for the feedback.

PS. Did you check these files with holidays?

Whatever calendar software people are using, export can often be done in iCal format.

We have 2 options here:

In project settings, store the path to an iCal file in Nextcloud Files. Each time we need to know the holidays, this file can be parsed.
Import an iCal file and store the holidays in Cospend's database tables

This requires some UI and backend development. I won't do it but I'm open to PRs. Let's leave this issue open in case someone want's to dive into that.

pawlosck commented 3 years ago

Ok, I understand. Maybe other programmer implement this function.

codingHahn commented 3 years ago

Could you also implement quarterly payment? (every three months)?

pawlosck commented 3 years ago

Try to choose Repeat -> "Monthly" and Frequency -> 3