julienXX / terminal-notifier

Send User Notifications on macOS from the command-line.
Other
6.38k stars 330 forks source link

-appIcon presence invokes extra icon #153

Closed unknown-- closed 8 years ago

unknown-- commented 8 years ago

If -appIcon is invoked then Terminal's icon is appended for whatever reason. Would it not be cleaner to just have the specified app's icon? I get that you might want to include Terminal's icon because the notification isn't generated naturally but shouldn't the end-user be able to specify this?

Normal: '/usr/local/bin/terminal-notifier -title 'Download Complete' -message "$TNAME"'

Redundant Terminal icon: '/usr/local/bin/terminal-notifier -title 'Download Complete' -message "$TNAME" -appIcon /Applications/Transmission.app/Contents/Resources/Transmission.icns'

Example

julienXX commented 8 years ago

Please see #131