Only use activate if dropdownLabel is passed too

julienXX / terminal-notifier

Send User Notifications on macOS from the command-line.

Other

6.37k stars 330 forks source link

Only use activate if dropdownLabel is passed too #225

Closed shalecraig closed 6 years ago

shalecraig commented 7 years ago

See https://github.com/julienXX/terminal-notifier/issues/223#issuecomment-305415020 for a lot more context

Disclaimers

I don't really write/know objective-c
I couldn't figure out the difference between options and defaults

julienXX commented 7 years ago

Thanks for the PR, I'll try to have a look quickly.

shalecraig commented 7 years ago

friendly bump 😄

julienXX commented 7 years ago

@shalecraig sorry while reviewing and testing your changes, I think I found another issue. I've got to do some more testing of the whole stuff sadly I don't have much time these days but I'll manage do do it somehow.

shalecraig commented 7 years ago

No worries. Figured I'd bump after a while.

Thanks for maintaining this awesome piece of Software. :)

julienXX commented 6 years ago

Closing for now. Version 2.0.0 as been released with alerter features removed https://github.com/julienXX/terminal-notifier/releases/tag/2.0.0