Crop contentImage to correct dimensions

julienXX / terminal-notifier

Send User Notifications on macOS from the command-line.

Other

6.38k stars 330 forks source link

Crop contentImage to correct dimensions #252

Closed forthrin closed 6 years ago

forthrin commented 6 years ago

I looked in closed issues and it has not already been answered
the macOS version you use: 10:13
terminal-notifier version: 2.0.0
how did you install terminal-notifier: Homebrew

If contentImage has wrong aspect ratio, crop it to create the correct dimensions.

julienXX commented 6 years ago

Hi thanks for the idea but I think that's not terminal-notifier responsibility to crop images so sorry but I won't add this feature.

forthrin commented 6 years ago

If it's a lot of code and libraries, then I agree. If it's a couple of lines, please reconsider.

julienXX commented 6 years ago

It's not a matter of lines of code, I prefer to follow the UNIX philosophy of small tools doing focused tasks that you can pipe together. You could use imagemagick do to do this and pipe the cropped image directly in terminal-notifier for example.

forthrin commented 6 years ago

I follow that. No problem.