search

juliencarponcy / trialexp

MIT License
2 stars 4 forks source link

Spike sorting merge PR #56

Closed juliencarponcy closed 10 months ago

juliencarponcy commented 12 months ago

I start to open the PR to progressively fix impossible merges. It is aimed to integrate progress on spike_sorting pipeline to the dev branch. I will commit later with merge editor and consult @teristam and @kouichi-c-nakamura for potential problematic conflicts

juliencarponcy commented 11 months ago

Great work! Just some minor comments.

There are some things I would like to refactor, e.g. too many implementation details in the script files, the functions should be defined elsewhere etc. But I think our first priority is to have a functional spike sorting pipeline ready. We can work on those refactors later.

You are absolutely correct about the refactors needed. Once the PR is merged and we're little more confident in the versatility of the code to different sessions / animals / tasks / aborted recordings etc, it will be easier to move more stuff out of the scripts to the package's methods

teristam commented 11 months ago

I will take over and start merging this PR now