search

julienfastre / docker-sogo

Run sogo in a docker container.
GNU General Public License v2.0
28 stars 14 forks source link

Some tweaks and improvements #8

Open SISheogorath opened 6 years ago

SISheogorath commented 6 years ago

As I want to use this projects in my Ansible infrastructure project I forked it.

I would like to contribute changes I do back so I provide the changes in branches like this one

But as they'll be based on my master branch which is probably going to be different from yours over time, you make want to cherry-pick stuff instead. (I also think about not using a github fork but instead use the same code but in an own repository as github forks have some bad side effects)

So if you are interested in working together here, this is my offer to you :)

julienfastre commented 6 years ago

Thanks for sharing this.

I need help to keep this project up-to-date. I need to add a sogo 4 version, but I have some projects and I fear for backward changes.

The projects are:

Do you share the same interests ?

I have poor knowledge of travis (I do use gitlab and gitlab-ci).

SISheogorath commented 6 years ago
  • adding mysql to the image, but I think we should create two separate image, to keep the image the slimest possible (but I do not know if this is really necessary)

We can either do this, or provide the libraries as parameter and install both by default but build them with one set for the uploads. That makes it easier to maintain.

  • I also would like to add create some image working on docker swarm

That should be easily possible by creating a second image for nginx that serves the static resources.

  • and I think it would be easier to handle the different version of sogo on different folder, instead of branches.

That mainly depends on how many different versions you want to maintain. For most projects I maintain, only maintain the latest version while still serving the old ones. So people should take care of keeping their stuff up to date.

Maintaining multiple Dockerfiles that are basically identical can become an annoying task ^^

cjunquera commented 3 years ago

Sooo, is this finished and safe to install?