search

julienrf / play-json-derived-codecs

MIT License
191 stars 34 forks source link

Update play-json dependency to 3.x, update README. Fixes #91 #92

Closed matmannion closed 6 months ago

matmannion commented 12 months ago

Adds support for play-json 3.0 with the new groupId on the dependency.

Fixes #91

julienrf commented 12 months ago

Thank you for the quick PR!

You will also have to reset the compatibility intention to Compatibility.None:

https://github.com/julienrf/play-json-derived-codecs/blob/214b5a19a61ae2ba9a50c76dd093f014ec961709/build.sbt#L10

And it seems we need to update our Scala.js dependency as well because play-json is using a very recent version of Scala.js.

https://github.com/julienrf/play-json-derived-codecs/blob/214b5a19a61ae2ba9a50c76dd093f014ec961709/project/plugins.sbt#L3

Dichotomia commented 8 months ago

Hello. Any chance to see this merged?

sdudzin commented 7 months ago

@julienrf any chance of merging this in the nearest future?

julienrf commented 7 months ago

Hello! Thank you for your interest. Can someone fix the CI failure according to the explanation at https://github.com/julienrf/play-json-derived-codecs/pull/92#issuecomment-1803870815?