julienrf / play-json-derived-codecs

MIT License
191 stars 34 forks source link

Update play-json library to 3.0.2, and scala-js to 1.13.0 #94

Closed griffhun closed 5 months ago

pawelpanasewicz commented 6 months ago

The build fails because it runs on older java version then some of the dependencies were built with. Maybe you could try to upgrade also the version of java in ci.yml

Maybe when added extra step to configure , something like this:

      # Set up Java
      - name: Set up JDK 11
        uses: actions/setup-java@v2
        with:
          java-version: '11'
          distribution: 'adopt'
pawelpanasewicz commented 6 months ago

Also I have noted that it would be good to rename the readme to change Play 2.9 with Play 3.0:

The artifacts are built for Scala and Scala.js 2.12, and 2.13, Play 2.9 and Shapeless 2.3.

julienrf commented 5 months ago

Thank you for your help, this has been superseded by #95