julienschmidt / go-http-routing-benchmark

Go HTTP request router and web framework benchmark
BSD 3-Clause "New" or "Revised" License
1.65k stars 238 forks source link

Adding go-resftul to benchmarks #11

Closed laher closed 10 years ago

laher commented 10 years ago

Hi Julien, I've added in go-resftul to the suite of benchmarks. go-restful does ok in some respects, but it comes in below average for RAM and speed. I'd say it's somewhat comparable to gorilla-mux, and a little better than Martini.

I hope you find the pull-request in decent shape. I kept to the alphabetical-ish ordering, so goRestful ends up in between goJsonRest and gorillaMux. I ran go fmt on it aswell, so it should all be in order. I haven't updated the readme with results because I figure it'd be best to keep using the same hardware for those figures.

As an aside, my interest in go-restful is that it's self-documenting and supports swagger. I'm deciding on which router to use, and your benchmark was really valuable in that assessment,

My conclusion is that I'm interested in seeing/creating swagger support for httprouter, and then using httprouter. I've already made something ugly to acheive this using go-restful/swagger's code. I'm keen to fork it into something less hackish, but I'd like to see if you have ideas about it first. I'll post my ugly code as a gist and send you an issue on the httprouter project itself.

Cheers, and thanks for all the good work on this stuff.

julienschmidt commented 10 years ago

Right on time. The next run is planned for this weekend :smiley:

The PR looks fine to me, thanks!

laher commented 10 years ago

Good stuff