search

julienschmidt / go-http-routing-benchmark

Go HTTP request router and web framework benchmark
BSD 3-Clause "New" or "Revised" License
1.65k stars 237 forks source link

Testing of Zeus failed #33

Closed mikespook closed 9 years ago

mikespook commented 9 years ago

Running go test -bench=. -timeout=20m but failed:

--- FAIL: TestRouters (2.72s)
    routers_test.go:78: Zeus in API Static: 301 - <a href="/articles">Moved Permanently</a>.

        ; expected GET /articles/
    routers_test.go:78: Zeus in API Static: 301 - <a href="/articles/wiki">Moved Permanently</a>.

        ; expected GET /articles/wiki/
    routers_test.go:78: Zeus in API Static: 301 - <a href="/codewalk">Moved Permanently</a>.

        ; expected GET /codewalk/
    routers_test.go:78: Zeus in API Static: 301 - <a href="/devel">Moved Permanently</a>.

        ; expected GET /devel/
    routers_test.go:78: Zeus in API Static: 301 - <a href="/gopher">Moved Permanently</a>.

        ; expected GET /gopher/
    routers_test.go:78: Zeus in API Static: 301 - <a href="/gopher/pencil">Moved Permanently</a>.

        ; expected GET /gopher/pencil/
    routers_test.go:78: Zeus in API Static: 301 - <a href="/play">Moved Permanently</a>.

        ; expected GET /play/
    routers_test.go:78: Zeus in API Static: 301 - <a href="/progs">Moved Permanently</a>.

        ; expected GET /progs/

I'd like to make a PR, but I am not familiar with Zeus.

julienschmidt commented 9 years ago

It has to be fixed in the router: https://github.com/daryl/zeus/issues/2 If they won't fix it before the next run, I'll simple kick Zeus out.

You can still run the benchmark with go test -run=None -bench=. -timeout=20m. This way the verification phase is skipped and only the benchmarks are run. But ignore the Zeus results then.

mikespook commented 9 years ago

Thanks!