search

julienschmidt / go-http-routing-benchmark

Go HTTP request router and web framework benchmark
BSD 3-Clause "New" or "Revised" License
1.65k stars 237 forks source link

Returing router instance, as in function loadEcho. #40

Closed vishr closed 9 years ago

vishr commented 9 years ago

Signed-off-by: Vishal Rana vr@labstack.com

julienschmidt commented 9 years ago

1) We still benchmark the framework (with minimal middleware & logging) not just the Router 2) There is no e.Router() in loadEcho: https://github.com/julienschmidt/go-http-routing-benchmark/blob/master/routers.go#L366 (but loadEchoSingle has to be fixed)

julienschmidt commented 9 years ago

Wait.. you are trying to change loadEcho. But still, see (1)

vishr commented 9 years ago

Echo is primarily an HTTP router so I think it should be represented as router. But I am okay if you don't think the same way.